Skip to content

Emit vaultless add-order IO#2770

Open
findolor wants to merge 1 commit into
rai-1063-settings-vaultless-iofrom
rai-1063-add-order-vaultless
Open

Emit vaultless add-order IO#2770
findolor wants to merge 1 commit into
rai-1063-settings-vaultless-iofrom
rai-1063-add-order-vaultless

Conversation

@findolor

@findolor findolor commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Emit vaultId == 0 only for IO explicitly marked vaultless.
  • Preserve generated nonzero random vault IDs for normal IO without explicit vault IDs.
  • Cover mixed vaultless and vault-backed inputs/outputs.

Validation

  • cargo test -p raindex_common add_order
  • cargo check -p raindex_common
  • Final stack: rainix-rs-static
  • Final stack: wasm target cargo test for raindex_quote, raindex_bindings, raindex_js_api, raindex_common
  • Final stack: npm run build && npm test in packages/raindex

Review

  • Staged local review completed with no actionable findings.

Refs RAI-1063.

@linear

linear Bot commented Jun 16, 2026

Copy link
Copy Markdown

RAI-1063

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 150a4d2a-f806-4b43-af02-00df2b6f9d90

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rai-1063-add-order-vaultless

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@findolor Graphite App

findolor commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label Raindex-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jun 16, 2026
Open
Open
Open
Open
Open
@findolor findolor self-assigned this Jun 17, 2026
@findolor findolor requested review from 0xgleb and JuaniRios June 17, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xgleb 0xgleb 0xgleb approved these changes
@JuaniRios JuaniRios JuaniRios approved these changes

Assignees

@findolor findolor

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@findolor @0xgleb @JuaniRios